Change the default value of actionItems to [] | Fixes #1178 #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbalsas
reviewed
Sep 12, 2018
matuzalemsteles
force-pushed
the
issue-1178
branch
from
1da1a60 to
ac5f1f9
Compare
matuzalemsteles
commented
Sep 12, 2018
| @@ -200,20 +200,12 @@ | |||
| * This renders the component's active content. | |||
| */ | |||
| {template .active} | |||
| {@param actionItems: list<?>} | |||
There was a problem hiding this comment.
hey @jbalsas, I'm removing the typing here so that at https://github.com/liferay/clay/pull/1181/files#diff-54445d58e09b53d03b6d0558828824f6R136 can set the default value if not passed.
Since we are typing actionItems above, we can ensure that the values are passed correctly.
Pull Request Test Coverage Report for Build 1176
💛 - Coveralls |
|
Just started reviewing :) |
Sent from 
carloslancha
suggested changes
Sep 17, 2018
packages/clay-management-toolbar/src/__tests__/ClayManagementToolbar.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.