Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1240 - Dropdown Menu added .dropdown-item-indicator-start and .dropdown-item-indicator-end for placing icons on either side of a dropdown-item and deprecated .dropdown-item-indicator #1245

Merged
merged 3 commits into from
Oct 31, 2018

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Oct 17, 2018

The pattern for icons on both sides:

<ul class="dropdown-menu dropdown-menu-indicator-end dropdown-menu-indicator-start">
    <li>
        <a class="dropdown-item">
            <span class="dropdown-item-indicator-start">
                <svg></svg>
            </span>
            Text
            <span class="dropdown-item-indicator-end">
                <svg></svg>
            </span>
        </a>
    </li>
</ul>

The pattern for icons on left:

<ul class="dropdown-menu dropdown-menu-indicator-start">
    <li>
        <a class="dropdown-item">
            <span class="dropdown-item-indicator-start">
                <svg></svg>
            </span>
            Text
        </a>
    </li>
</ul>

The pattern for icons on right:

<ul class="dropdown-menu dropdown-menu-indicator-end">
    <li>
        <a class="dropdown-item">
            Text
            <span class="dropdown-item-indicator-end">
                <svg></svg>
            </span>
        </a>
    </li>
</ul>

…art` and `.dropdown-item-indicator-end` for placing icons on either side of a dropdown-item and deprecated `.dropdown-item-indicator`
@matuzalemsteles
Copy link
Member

hey @pat270, we'll have to modify the markup in ClayDropdown too, right?

@pat270
Copy link
Member Author

pat270 commented Oct 25, 2018

@matuzalemsteles yes, clay-dropdown needs an update, but it will still work the old way. Also added docs.

@matuzalemsteles
Copy link
Member

ok, thanks a lot @pat270. I'll create an issue to update the markups then.

@carloslancha carloslancha merged commit 71e8a0e into liferay:develop Oct 31, 2018
@pat270 pat270 deleted the clay-1240 branch May 16, 2019 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants