Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1250 - ClayCreationMenuDropdown should accept empty array or undefined primaryItems #1251

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Fixes #1250 - ClayCreationMenuDropdown should accept empty array or undefined primaryItems #1251

merged 3 commits into from
Oct 24, 2018

Conversation

carloslancha
Copy link
Contributor

No description provided.

@carloslancha carloslancha changed the title Fixes #1250 - Regen snapshots Fixes #1250 - ClayCreationMenuDropdown should accept empty array or undefined primaryItems Oct 22, 2018
@matuzalemsteles
Copy link
Member

Hey guys, are we in trouble with Travis?

@julien
Copy link
Contributor

julien commented Oct 23, 2018

@matuzalemsteles I had issues until last night but everything seems to be back to normal now.

@matuzalemsteles
Copy link
Member

Thanks @julien, I was finding it strange because I was not seeing the CI checks here on github.

@matuzalemsteles
Copy link
Member

Just started reviewing :)

:octocat: Sent from GH.

@julien
Copy link
Contributor

julien commented Oct 23, 2018

No problem @matuzalemsteles, just so you know I had to restart the build several times from travis.

Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julien julien merged commit c5c192f into liferay:develop Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants