Fixes #1266 Reflow sidenav to prevent issue in IE11 #1267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat270
added a commit
to pat270/clay
that referenced
this pull request
Oct 29, 2018
|
New pull: #1271 Hey @fortunatomaldonado, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1266
https://issues.liferay.com/browse/LPS-86163
Being able to reflow the content will fix the issue in IE11. I was able to find examples of reflowing content which can be found here. I was unable to get the reflow to work using offsetWidth and found using .css() worked. Adding the reflow to _renderUI will make sure this issue will not be reproducible for any sidenav created.
Let me know if there is a better way to cause the reflow and if there are any questions or comments.
Thank you.