Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1171 - Implementation of loading indicator #1286

Merged
merged 2 commits into from
Nov 13, 2018
Merged

Fixes #1171 - Implementation of loading indicator #1286

merged 2 commits into from
Nov 13, 2018

Conversation

bryceosterhaus
Copy link
Member

@bryceosterhaus bryceosterhaus commented Nov 5, 2018 •
edited
Loading

@bryceosterhaus bryceosterhaus changed the title Implementation for https://github.com/liferay/clay/issues/1171 Implementation for #1171 Nov 5, 2018
@bryceosterhaus bryceosterhaus changed the title Implementation for #1171 Implementation of loading indicator Nov 5, 2018
@bryceosterhaus bryceosterhaus changed the base branch from master to develop November 5, 2018 19:50
@bryceosterhaus bryceosterhaus force-pushed the loadingComponent branch 4 times, most recently from 8c2b367 to 33ba279 Compare November 5, 2018 20:22
@bryceosterhaus
Copy link
Member Author

Anyone know how to get npm run testSoy to work locally? I am getting this error

FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all dependencies for configuration ':runtime'.
> Could not download soy.jar (com.google.template:soy:2015-04-10)
   > Could not get resource 'https://cdn.lfrs.sl/repository.liferay.com/nexus/content/groups/public/com/google/template/soy/2015-04-10/soy-2015-04-10.jar'.
      > Premature end of Content-Length delimited message body (expected: 1596448; received: 244420

@julien
Copy link
Contributor

julien commented Nov 6, 2018

Hey @bryceosterhaus ,
I haven't run into this error before but I've had similar issues while downloading dependencies with gradle, the URL you mentioned is accesible for me at this time ... but it looks like it wasn't when you tried to run the task ... maybe there was an issue with this cdn

@bryceosterhaus bryceosterhaus changed the title Implementation of loading indicator Fixes #1171 - Implementation of loading indicator Nov 6, 2018
@bryceosterhaus
Copy link
Member Author

@julien yep that was the issue. I was able to download the dependencies today

@matuzalemsteles
Copy link
Member

Just started reviewing :)

:octocat: Sent from GH.

matuzalemsteles
matuzalemsteles approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matuzalemsteles
Copy link
Member

hey @bryceosterhaus, One thing before we merge this here, can you care to add this to the clayui.com documentation 🙂? Thank you very much.

@bryceosterhaus
Copy link
Member Author

@matuzalemsteles just added soy and web component examples to clayui.com docs

@jbalsas
Copy link
Contributor

jbalsas commented Nov 13, 2018

Looking great, merging! 👍

@jbalsas jbalsas merged commit 1718eb1 into liferay:develop Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matuzalemsteles matuzalemsteles matuzalemsteles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bryceosterhaus @julien @matuzalemsteles @jbalsas