Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1242 - Adds an alert informing the discontinuation of the title and focusable API #1331

Merged
merged 6 commits into from
Nov 29, 2018
Merged

Fixes #1242 - Adds an alert informing the discontinuation of the title and focusable API #1331

merged 6 commits into from
Nov 29, 2018

Conversation

matuzalemsteles
Copy link
Member

No description provided.

@matuzalemsteles matuzalemsteles mentioned this pull request Nov 26, 2018
Closed
@matuzalemsteles
Copy link
Member Author

Just for info: A malicious package (flatmap-stream) that was dependent on the event-stream package was removed from NPM... Just updating yarn.lock to make sure we're removing it...

More information:

@matuzalemsteles matuzalemsteles mentioned this pull request Nov 27, 2018
Closed
jbalsas and others added 4 commits November 27, 2018 14:15
@jbalsas @matuzalemsteles
Revert "Update: Added pointer-events: none to `.navbar-text-truncat…
2ff3df8 
…e`, `.breadcrumb-text-truncate`, and `.lexicon-icon` to prevent focus highlight in IE11 when clicking links that contain those elements"

This reverts commit 0bec132.
@jbalsas @matuzalemsteles
Fixes liferay#1242 - (BREAKING CHANGE) Removes title from the svg ele…
d57c411 
…ment and focusable attribute. Use role=presentation instead and rely on usage to provide proper semantics when using/wrapping the icon
@jbalsas @matuzalemsteles
Fixes liferay#1242 - Regen snapshots
4f375cd
@matuzalemsteles
Fixes liferay#1242 - Adds an alert informing the discontinuation of t…
d7a1724 
…he title and focusable API
@pat270
Copy link
Member

pat270 commented Nov 27, 2018

@jbalsas @matuzalemsteles removing the focusable="false" attribute re-introduces svg icons receiving focus on tab in IE11 and Edge. This is an IE specific attribute.

pat270
pat270 requested changes Nov 27, 2018
View reviewed changes
packages/clay-icon/src/ClayIcon.js Outdated Show resolved Hide resolved
@jbalsas
Copy link
Contributor

jbalsas commented Nov 27, 2018

Got it, we can leave that then. Does the rest look good to you @pat270?

@pat270
Copy link
Member

pat270 commented Nov 27, 2018

LGTM. Can we roll back #1307 and do the same there?

@jbalsas jbalsas merged commit d837fcb into liferay:develop Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pat270 pat270 pat270 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matuzalemsteles @pat270 @jbalsas