ClayCSS: Create markup for labels in input #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t are interactive Fixes liferay#1283 - Mixin `clay-label-size` should be able to resize `.label-item .lexicon-icon` and added options to configure `$label-link-color`, `$item-spacer-x`, `$item-spacer-y`, `$sticker-size`, and `$sticker-border-radius` Fixes liferay#1283 - Labels added options to configure `$label-sticker-border-radius`, `$label-sticker-size`, `$label-item-spacer-y` Fixes liferay#1283 - Labels added Sass maps `$label-primary`, `$label-secondary`, `$label-success`, `$label-info`, `$label-warning`, `$label-danger`, `$label-light`, `$label-dark` and use mixin `clay-label-variant` to style labels Fixes liferay#1283 - Labels deprecated `$label-primary-*`, `$label-secondary-*`, `$label-success-*`, `$label-info-*`, `$label-warning-*`, `$label-danger-*`, `$label-light-*`, `$label-dark-*` variables Fixes liferay#1283 - Labels added Sass maps `$label-primary-close`, `$label-secondary-close`, `$label-success-close`, `$label-info-close`, `$label-warning-close`, `$label-danger-close`, `$label-light-close`, `$label-dark-close`
Fixes liferay#1283 - Forms `.form-control.focus` should show input in focus state
…d have hover state color Fixes liferay#1283 - Labels `button.label` should have cursor pointer and have same styles as `a.label`
Test Site: Update SVG icon markup to use `focusable="false" role="presentation"`
(clayui.com) Update SVG icon markup to use `focusable="false" role="presentation"`
|
hey @pat270, the icons on the label are bigger, was that supposed to happen or do we have to change some markup? See example: |
|
@matuzalemsteles The Lexicon team requested the size of the icons inside labels be 16px. https://issues.liferay.com/browse/LEXI-393. They need to change the rules, change their mock ups, or make the times svg smaller. |
|
/cc @victorvalle ? |
|
Hi! The icons inside 24px height labels have a size of 12x12 instead of 16x16. Sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.