Fixes #1354 Clay CSS Buttons in Input Group should be more customizable #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing new base button classes with options to configure `breakpoint-down`, `border-color`, `border-radius`, `border-style`, `border-width`, `display`, `font-size`, `font-weight`, `height`, `line-height`, `padding-bottom`, `padding-left`, `padding-right`, `padding-top`, `transition`, `user-select`, `vertical-align`, `white-space`, `width`, `inline-item-font-size`, `section-font-size`, `section-font-weight`, `section-line-height`, `font-size-mobile`, `height-mobile`, `padding-bottom-mobile`, `padding-left-mobile`, `padding-right-mobile`, `padding-top-mobile`, `width-mobile`
…up-item-margin-left`, `$input-group-inset-item-padding-left`, `$input-group-inset-item-padding-right` and Sass maps `$input-group-lg-item-btn`, `$input-group-lg-item-btn-monospaced`, `$input-group-lg-inset-item-btn`, `$input-group-lg-inset-item-form-file-btn`, `$input-group-sm-item-btn`, `$input-group-sm-item-btn-monospaced`, `$input-group-sm-inset-item-btn`, `$input-group-sm-inset-item-form-file-btn` for more customization options
…p-inset-form-file-btn`
|
Looks great, @pat270! My main concern was that we were losing some defaults here, introducing a breaking change, but if I'm reading the code correctly, we're setting the default values of the new variables to the old I'm merging it in 👍 |
|
@jbalsas yes default values were moved to variables. There were some redundant properties that are defined in the normal size and were being defined again in lg and sm sizes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.