Breaking: Use open instead of closed to toggle sidenav #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…educe specificity, active class should be removed from toggler
|
👍 Merged and pushed to master. Thanks :) View just my changes: pat270:5a4c9df95a...4c0d3d0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://liferay.github.io/lexicon/content/sidenav/
http://liferay.github.io/lexicon/content/documents-and-media/
Breaking: Sidenav should use open instead of closed to display nav for easier customization with common tutorials found on the web
Update: Move sidenav transition to variable
Update: Reduce css specificity of sidenav js api
Update: Active class should be removed from toggler when using sidenav-close button
Hey @natecavanaugh, this fixes #170 and should go in with https://issues.liferay.com/browse/LPS-65790. Everything should function the same except sidenavs toggle with open instead of closed. The closed class is still needed by the js api for now.