Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary use of minValue and maxValue in the ProgressBar #497

Merged
merged 2 commits into from
Jan 31, 2018

Conversation

matuzalemsteles
Copy link
Member

In the API, it no longer uses minValue and maxValue.

@jbalsas
Copy link
Contributor

jbalsas commented Jan 31, 2018

Hey @matuzalemsteles, why are those no longer necessary? How does the component work now?

@matuzalemsteles
Copy link
Member Author

matuzalemsteles commented Jan 31, 2018

hey @jbalsas, it no longer has the possibility of being able to choose the value of minValue and maxValue the logic is in Soy, just pass the value. This was corresponding to this PR deprecate/metal-clay-components#252 e82590f#diff-685086abd487edf3c96e4f84a1af38ba

@julien
Copy link
Contributor

julien commented Jan 31, 2018

@jbalsas, @matuzalemsteles if I remember correctly the minValue would always be 0 and maxValue would always be 100. This is something we saw with @carloslancha and UX.

@jbalsas jbalsas merged commit d07ce0a into liferay:develop Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants