Add Chart examples to claycss.com (Fixes #456) #515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbalsas
suggested changes
Feb 6, 2018
| @@ -12,7 +12,10 @@ | |||
| "mcritic": "mcritic packages/ --ignore '**/{browserslist-config-clay-components,claycss.com,generator-metal-clay,node_modules}/**'", | |||
| "prettier": "prettier-eslint packages/clay-*/src/*.js packages/clay-*/src/**/*.js", | |||
| "start": "http-server . -p 4000", | |||
| "test": "npm run build && npm run jest && npm run a11y" | |||
| "test": "npm run build && npm run jest && npm run a11y", | |||
| "electric": "cd packages/clay && npm run build && cd ../clay-charts && npm run compile && npm run sass", | |||
There was a problem hiding this comment.
Hey @julien, even if we might incur into some overhead now, I assume at some point we'll want to add other components as well, so why not just have these do:
...
"electric": "npm run build && cd packages/claycss.com && el",
"web": "npm run electric -- run"
"deploy": "npm run electric -- deploy"
...| @@ -32,10 +32,10 @@ module.exports = { | |||
| return generateIconData(data); | |||
| }, | |||
| codeMirrorLanguages: ['xml', 'htmlmixed', 'soy'], | |||
| metalComponents: ['electric-quartz-components'], | |||
| metalComponents: ['electric-quartz-components', 'clay-charts'], | |||
There was a problem hiding this comment.
While we're at it, we might as well add the rest of clay components, ideally in a programatic way 😉
There was a problem hiding this comment.
That sounds like a better idea, thanks.
|
Pull request submitted to #521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.