Create data API to replace columns in Charts Fixes #526
#550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes liferay#526 Add polling_interval option to Charts Fixes liferay#544
|
I'm wondering if we couldn't get rid of the |
|
Hey @brunobasto and @bryceosterhaus, Would it be an issue for you if we replaced Thanks! |
|
Hey guys, I'm closing this pull request since we're also going to replace trailing underscores with leading underscores (see #574), but I still need your precious feedback when you can so feel free to comment even though this one is closed. Thanks! |
|
Hey @julien, I think it should be fine for me. Thanks! |
|
Ok, Thanks @brunobasto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.