Add flag to indicate when focusable is true or not | Fixes #536 #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/clay-icon/src/ClayIcon.js
Outdated
| @@ -25,6 +25,15 @@ ClayIcon.STATE = { | |||
| */ | |||
| elementClasses: Config.string(), | |||
|
|
|||
| /** | |||
| * Flag to indicate when svg focusable or not. | |||
There was a problem hiding this comment.
Typo: Flag to indicate if the svg is focusable or not
There was a problem hiding this comment.
That looks better, thanks!
| @@ -20,6 +21,12 @@ | |||
| {/if} | |||
| " | |||
|
|
|||
| {if $focusable} | |||
There was a problem hiding this comment.
Can this be written focusable="{$focusable == true}" ?
There was a problem hiding this comment.
No, the attributes do not allow bool to be used focusable="{$focusable == true ? 'true' : 'false'}"(is that what you meant?). Sounds good to you?
There was a problem hiding this comment.
Nah, leave it as it was 😄 Thx!
|
Merged, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.