Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#594 Update .table styles to match Lexicon 2 #595

Closed
wants to merge 2 commits into from

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Feb 21, 2018

No description provided.

…ta-border-bottom-width`, `$table-data-border-left-width`, `$table-data-border-right-width`, `$table-data-border-top-width`, `$table-data-border-color`, `$table-data-border-style`, `$table-data-vertical-align`

Update: (liferay#594) Table Bordered added option to configure `$table-bordered-border-width`
@coveralls
Copy link

Pull Request Test Coverage Report for Build 296

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.184%

Totals Coverage Status
Change from base Build 292: 0.0%
Covered Lines: 4390
Relevant Lines: 4624

💛 - Coveralls

@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

Copy link
Contributor

@carloslancha carloslancha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pat270 test-table-view-template.html is not updated with this changes

@pat270
Copy link
Member Author

pat270 commented Feb 22, 2018

@carloslancha test-table-view-template.html doesn't need to be updated because it's using `.table-list`? Do you mean the h4 element?

@carloslancha
Copy link
Contributor

Hey @pat270 yep, just to be consistent between examples

…nstead of `h4` for `.table-title` because requested by Clay components team
@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@carloslancha
Copy link
Contributor

Rebased and resent #631

@pat270 pat270 deleted the clay-594 branch July 11, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants