#610 Check for Number instead of Boolean on axisY.tick.count prop #611

kienD · 2018-02-21T19:34:50Z

Fixes #610

carloslancha · 2018-02-21T19:39:40Z

Hey @kienD please rewrite the commit message to add | Fixes #610, it helps us with automatic changelog on release. Thx!

…y#610

kienD · 2018-02-21T19:43:41Z

@carloslancha,

Updated! I'll make note of that for the future as well.

Thanks!

coveralls · 2018-02-21T19:44:51Z

Pull Request Test Coverage Report for Build 320

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.184%

Totals
Change from base Build 286:	0.0%
Covered Lines:	4390
Relevant Lines:	4624

💛 - Coveralls

carloslancha · 2018-02-22T08:55:07Z

Merged, thx!

kienD changed the title ~~#610 Check flor Number instead of Boolean on axisY.tick.count prop~~ #610 Check for Number instead of Boolean on axisY.tick.count prop Feb 21, 2018

kienD force-pushed the issue-610 branch from 2acc483 to 8f5a032 Compare February 21, 2018 19:37

kienD force-pushed the issue-610 branch from 8f5a032 to 7dd2078 Compare February 21, 2018 19:41

Tick count for axisY should expect a number not a bool | Fixes lifera…

82499a1

…y#610

kienD force-pushed the issue-610 branch from 7dd2078 to 82499a1 Compare February 21, 2018 19:43

carloslancha merged commit 9b14c3e into liferay:master Feb 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#610 Check for Number instead of Boolean on axisY.tick.count prop #611

#610 Check for Number instead of Boolean on axisY.tick.count prop #611

kienD commented Feb 21, 2018 •

edited

Loading

carloslancha commented Feb 21, 2018

kienD commented Feb 21, 2018

coveralls commented Feb 21, 2018 •

edited

Loading

carloslancha commented Feb 22, 2018

#610 Check for Number instead of Boolean on axisY.tick.count prop #611

#610 Check for Number instead of Boolean on axisY.tick.count prop #611

Conversation

kienD commented Feb 21, 2018 • edited Loading

carloslancha commented Feb 21, 2018

kienD commented Feb 21, 2018

coveralls commented Feb 21, 2018 • edited Loading

Pull Request Test Coverage Report for Build 320

💛 - Coveralls

carloslancha commented Feb 22, 2018

kienD commented Feb 21, 2018 •

edited

Loading

coveralls commented Feb 21, 2018 •

edited

Loading