Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the dispose has already been done and does nothing | Fixes #582 #625

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

matuzalemsteles
Copy link
Member

hey @carloslancha, the messages from warn happened when the dispose was made on the components that used ClayAlertBase, the dispose happened from top to bottom and when it arrived in ClayAlertBase in some cases it had no more reference of _visible... The way to omit this is to check when it has already been disposed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 335

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 82.148%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/clay-alert/src/ClayAlertBase.js 6 7 85.71%
Totals Coverage Status
Change from base Build 328: 0.006%
Covered Lines: 4459
Relevant Lines: 4698

💛 - Coveralls

@carloslancha
Copy link
Contributor

Makes sense, thx @matuzalemsteles

@carloslancha carloslancha merged commit 0d7333e into liferay:develop Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants