Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use electric-clay-components instead of electric-quartz-components #534 #635

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

zenorocha
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 23, 2018

Pull Request Test Coverage Report for Build 361

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.983%

Totals Coverage Status
Change from base Build 356: 0.0%
Covered Lines: 4537
Relevant Lines: 4787

💛 - Coveralls

@matuzalemsteles
Copy link
Member

Hey @zenorocha, can you regenerate the yarn.lock with changes?

@zenorocha
Copy link
Contributor Author

Done @matuzalemsteles ;)

@matuzalemsteles
Copy link
Member

Thanks. Merged!

@matuzalemsteles matuzalemsteles merged commit d7794e9 into develop Feb 23, 2018
@zenorocha zenorocha deleted the clay-components branch February 23, 2018 19:09
@carloslancha
Copy link
Contributor

Hey @zenorocha with this changes we get this error when we try to render a soy component in the electric site:

Uncaught TypeError: comp.getRenderer(...).renderInsidePatch is not a function

the code that causes it is:

{call ClayButton.render}
   {param label: 'whatever' /}
{/call}

@carloslancha
Copy link
Contributor

carloslancha commented Feb 24, 2018

We also get this error
Warning: Error: Invalid state passed to 'items'. Expected type 'array', but received type 'string'. Passed to 'ClayDropdown'.

from this code:

```text/html
<clay-dropdown
	items='[{"label": "Action", "url": "#1"},{"separator": true, "type": : "group"},{"label": "Scope", "url": "#1"}]'
	spritemap="/vendor/lexicon/icons.svg"
	triggerLabel="Primary"
	triggerStyle="primary">
</clay-dropdown>
\```

There we want to render the use, not the result, so it shouldn't try to execute it.

@zenorocha

@zenorocha
Copy link
Contributor Author

Hmm, this PR shouldn't introduce that error. If that's the case, it's better to revert the commit and use quartz components until the problem is figured it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants