-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClayCSS Update Several pages #653
Conversation
…, any disabled checkbox should have `disabled` class on its parent `.dropdown-item`, and add example of `.form-group`
….reference-mark`, add `.reference-mark` to Custom Radio
Site: Grid add more detailed docs about various containers
Pull Request Test Coverage Report for Build 391
💛 - Coveralls |
Just started reviewing :) |
<article id="clay-custom-checkbox"> | ||
|
||
### Custom Checkbox | ||
<article id="custom-checkbox"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pat270, the clay-custom-checkbox
he adds via CSS always on the second WEB COMPONENTS
tab, it was a way that Chema found to have the HTML highlights and in the Web components
tab name, we have a list huge in _code.scss
to do this, maybe we can improve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the selector li:nth-last-child(3) + li > button
to style the Web Components tab. The order should be Soy, Web Components, Html always. There will be problems if there are 3 item code example tabs that don't have Web Components as the second item (maybe in charts). We might be able to add some id at the top of the page so this only applies to the components library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. Thanks @pat270 🙂
… and update focus styles
Just started reviewing :) |
Merged, thanks! |
No description provided.