Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClayCSS Update Several pages #653

Merged
merged 10 commits into from
Feb 27, 2018
Merged

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Feb 27, 2018

No description provided.

@coveralls
Copy link

coveralls commented Feb 27, 2018

Pull Request Test Coverage Report for Build 391

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.09%) to 81.868%

Files with Coverage Reduction New Missed Lines %
packages/clay-table/src/ClayTable.soy.js 1 83.9%
packages/clay-link/src/ClayLink.soy.js 1 84.65%
packages/clay-button/src/ClayButton.soy.js 2 82.72%
packages/clay-card-grid/src/ClayCardGrid.soy.js 34 61.22%
Totals Coverage Status
Change from base Build 377: -0.09%
Covered Lines: 4477
Relevant Lines: 4734

💛 - Coveralls

@matuzalemsteles
Copy link
Member

Just started reviewing :)

:octocat: Sent from GH.

<article id="clay-custom-checkbox">

### Custom Checkbox
<article id="custom-checkbox">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pat270, the clay-custom-checkbox he adds via CSS always on the second WEB COMPONENTS tab, it was a way that Chema found to have the HTML highlights and in the Web components tab name, we have a list huge in _code.scss to do this, maybe we can improve this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the selector li:nth-last-child(3) + li > button to style the Web Components tab. The order should be Soy, Web Components, Html always. There will be problems if there are 3 item code example tabs that don't have Web Components as the second item (maybe in charts). We might be able to add some id at the top of the page so this only applies to the components library.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Thanks @pat270 🙂

@matuzalemsteles
Copy link
Member

Just started reviewing :)

:octocat: Sent from GH.

@matuzalemsteles
Copy link
Member

Merged, thanks!

@matuzalemsteles matuzalemsteles merged commit bd6fd77 into liferay:develop Feb 27, 2018
@pat270 pat270 deleted the claycss-docs branch March 6, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants