Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generate icon data | Fixes #696 #698

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

matuzalemsteles
Copy link
Member

@coveralls
Copy link

Pull Request Test Coverage Report for Build 443

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 81.811%

Totals Coverage Status
Change from base Build 441: 0.02%
Covered Lines: 4482
Relevant Lines: 4746

💛 - Coveralls

@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@carloslancha
Copy link
Contributor

Why the change of folder guys? I'm merging it anyway, just to know :)
@matuzalemsteles

@carloslancha carloslancha merged commit 1becf22 into liferay:develop Mar 6, 2018
@matuzalemsteles
Copy link
Member Author

Hey @carloslancha, this file was in the lib folder, but for reasons we added lib to .gitignore. by changes of the package of Clay and we ended up not realizing the removal of this file and this one was in our machines and we were not affected by this error, but it was not being tracked by git and when it changed the name of the folder, it ended up affecting us.

But on the change from claycss.com to clayui.com maybe it's the domain change. Maybe it is that. I do not know 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants