Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag type JSDOC when use multiple types | Fixes #736 #737

Merged
merged 3 commits into from
Mar 15, 2018

Conversation

matuzalemsteles
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Mar 14, 2018

Pull Request Test Coverage Report for Build 529

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.978%

Totals Coverage Status
Change from base Build 520: 0.0%
Covered Lines: 4588
Relevant Lines: 4852

💛 - Coveralls

@carloslancha
Copy link
Contributor

Hey @matuzalemsteles nice work! Could you please order the params alphabetically too?

Current:

 	 * @instance
 	 * @memberof ClayAlert
	 * @type {?(string|undefined)}
 	 * @default undefined

Expected:

 	 * @default undefined
 	 * @instance
 	 * @memberof ClayAlert
	 * @type {?(string|undefined)}

Thx!

@carloslancha
Copy link
Contributor

Could you please also do this changes for clay-charts?

@matuzalemsteles
Copy link
Member Author

Hey @carloslancha, I just forgot to track the changes in clay-charts 😅, I'll do it now, thanks!

@carloslancha carloslancha merged commit ff8e9dd into liferay:develop Mar 15, 2018
@carloslancha
Copy link
Contributor

Merged, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants