Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#788) Atlas adjust font sizes #797

Merged
merged 1 commit into from
Apr 16, 2018
Merged

(#788) Atlas adjust font sizes #797

merged 1 commit into from
Apr 16, 2018

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Apr 13, 2018

No description provided.

…mponent font sizes should be adjusted

Update: (liferay#788) Atlas Global variables `$font-size-base` to `16px`, `$font-size-sm` to `14px`, `$font-size-lg` to `18px`

Update: (liferay#788) Atlas Alert change `font-size` to `14px`

Update: (liferay#788) Atlas Badge change `font-size` to `10px`

Update: (liferay#788) Atlas Label change `.label` ` font-size` to `10px` and `.label-lg` `font-size` to `12px`

Update: (liferay#788) Atlas Sticker change `.sticker` `font-size` to `10px`

Update: (liferay#788) Atlas Breadcrumb change `font-size` to `14px`

Update: (liferay#788) Atlas Button change `.btn` `font-size` to `16px`, `.btn-sm` `font-size` to `14px`, `.btn-lg` `font-size` to `18px`, and Buttons should keep original heights `40px`, `32px`, `48px` respectively

Update: (liferay#788) Atlas Card `.card-title`, `.card-subtitle`, `.card-link` font to `14px`

Update: (liferay#788) Atlas Dropdown set `$dropdown-font-size` to `14px`, `$dropdown-header-font-size` to `14px`, `$dropdown-subheader-font-size` to `12px`

Update: (liferay#788) Atlas Form Label set `font-size` to `14px`

Update: (liferay#788) Atlas Sheet `.sheet-subtitle`, `.sheet-tertiary-title` font sizes to `14px`

Update: (liferay#788) Atlas Form Feedback font to `14px` and weight to `400`

New: (liferay#788) List Group add option to set `$list-group-font-size`, Atlas set `$list-group-font-size` to `14px`, `$list-group-header-title` font to `12px`, `$list-group-title` font to `14px`

Update: (liferay#788) Atlas Modal `.modal-title` font-weight to `700`

Update: (liferay#788) Atlas Multi Step Nav font to `14px`

New: (liferay#788) Nav add option to set `$nav-font-size`, Atlas set it to `14px`

Update: (liferay#788) Navbar add option to set `$navbar-font-size`, Atlas set to `14px` and Application Bar, Management Bar, Navigation Bar should inherit it

Update: (liferay#788) Atlas Application Bar `.navbar-title` font to `18px`

New: (liferay#788) Mixin `clay-navbar-variant` add option to set `btn-font-size` and `btn-font-size-mobile` and should inherit from `$navbar-font-size` by default

Update: (liferay#788) Pagination `.pagination-results` should use `$pagination-font-size` and convert values to rems

Update: (liferay#788) Panel `.panel-title` font to `14px`

Update: (liferay#788) Progress Bar `$progress-group-addon-font-size` to `14px`

Update: (liferay#788) Atlas Sidebar `.sidebar-dt` font to `12px` and `.sidebar-dd` font to `14px`

Update: (liferay#788) Subnav Tbar `.subnav-tbar .component-title` font to `14px` and `text-transform` to `normal`

Update: (liferay#788) Mixin `clay-tbar-variant` added option to set `font-size`, `btn-line-height`, and `$btn-font-weight`

Update: (liferay#788) Atlas Table `.table-divider` font to `12px` and should be `32px` tall

Update: (liferay#788) Table added option to set `$table-font-size`, Atlas set `$table-font-size` and `$table-list-font-size` to `14px`
@coveralls
Copy link

coveralls commented Apr 13, 2018

Pull Request Test Coverage Report for Build 611

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.946%

Totals Coverage Status
Change from base Build 608: 0.0%
Covered Lines: 4637
Relevant Lines: 4902

💛 - Coveralls

@jbalsas
Copy link
Contributor

jbalsas commented Apr 15, 2018

Hey @pat270, why use an <h4> for the modal dialog instead of the <div>, or what I assume would be better, an <h1>?

If necessary, we would need to also update ClayModal

@pat270
Copy link
Member Author

pat270 commented Apr 16, 2018

@jbalsas The document with font updates also had specific h tags and I forgot to undo this change. I asked them to remove it since h tags should depend on the structure of the document which we have no control over.

@jbalsas
Copy link
Contributor

jbalsas commented Apr 16, 2018

Sounds good, thanks @pat270! We might want to consider using a more semantic markup for this... 🤔

@jbalsas jbalsas merged commit 6c5b92c into liferay:develop Apr 16, 2018
@pat270
Copy link
Member Author

pat270 commented Apr 16, 2018

I'm open to suggestions, just not sure what we can do since the markup would depend on the content and how it's structured.

@jbalsas
Copy link
Contributor

jbalsas commented Apr 16, 2018

No rush, just thinking out loud :)

@pat270 pat270 deleted the clay-788 branch July 11, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants