Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ClayTooltip component | Fixes #929 #940

Merged
merged 2 commits into from
May 25, 2018
Merged

Create ClayTooltip component | Fixes #929 #940

merged 2 commits into from
May 25, 2018

Conversation

julien
Copy link
Contributor

@julien julien commented May 24, 2018

No description provided.

@julien julien requested a review from carloslancha May 24, 2018 11:13
@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 807

  • 24 of 30 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 81.269%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/clay-tooltip/src/ClayTooltip.js 24 30 80.0%
Totals Coverage Status
Change from base Build 805: -0.04%
Covered Lines: 4974
Relevant Lines: 5296
💛 - Coveralls

@carloslancha
Copy link
Contributor

LGTM but we need to find out what is happening with Align, is not working 100% fine.

@julien
Copy link
Contributor Author

julien commented May 25, 2018

Thanks @carloslancha,

I guess we can go on with this and check what's going on with Align or look for an alternative.

@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@carloslancha carloslancha merged commit 73d68ae into liferay:develop May 25, 2018
@julien julien deleted the issue-929 branch May 29, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carloslancha carloslancha Awaiting requested review from carloslancha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julien @carloslancha @coveralls