Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove select all and deselect all buttons from Management Toolbar | Fixes #954 #955

Merged
merged 4 commits into from
May 30, 2018
Merged

Remove select all and deselect all buttons from Management Toolbar | Fixes #954 #955

merged 4 commits into from
May 30, 2018

Conversation

carloslancha
Copy link
Contributor

No description provided.

@carloslancha carloslancha changed the title Regen soy tests | Fixes #954 Remove select all and deselect all buttons from Management Toolbar | Fixes #954 May 29, 2018
@coveralls
Copy link

coveralls commented May 29, 2018

Pull Request Test Coverage Report for Build 858

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 81.396%

Files with Coverage Reduction New Missed Lines %
packages/clay-management-toolbar/src/ClayManagementToolbar.soy.js 2 88.4%
packages/clay-dataset-display/src/ClayDatasetDisplay.soy.js 3 79.17%
packages/clay-dataset-display/src/ClayDatasetDisplay.js 3 83.33%
Totals Coverage Status
Change from base Build 857: -0.09%
Covered Lines: 5069
Relevant Lines: 5410

💛 - Coveralls

@matuzalemsteles
Copy link
Member

Just started reviewing :)

:octocat: Sent from GH.

@matuzalemsteles
Copy link
Member

LGTM!

hey @carloslancha could you resolve the conflicts and resubmit?

@jbalsas jbalsas merged commit 53e13ff into liferay:develop May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants