Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emit the itemClicked event from ClayNavigationBar | Fixes #981 #982

Merged
merged 2 commits into from
Jun 11, 2018

Conversation

matuzalemsteles
Copy link
Member

No description provided.

@carloslancha
Copy link
Contributor

Hi @matuzalemsteles make this component extend from ClayComponent instead changing how the event is being emitted and everything should work fine

@coveralls
Copy link

coveralls commented Jun 8, 2018

Pull Request Test Coverage Report for Build 905

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.013%

Totals Coverage Status
Change from base Build 899: 0.0%
Covered Lines: 5102
Relevant Lines: 5468

💛 - Coveralls

@matuzalemsteles matuzalemsteles changed the title Pass the event name to this.emit | Fixes #981 Fix emit the itemClicked event from ClayNavigationBar | Fixes #981 Jun 8, 2018
@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@carloslancha carloslancha merged commit 654da35 into liferay:master Jun 11, 2018
@carloslancha
Copy link
Contributor

Merged, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants