LPD-42473 Instead of setting a width from image2 plugin, we'll do it in portal #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…directly inside portal when rendering the image
markocikos
reviewed
Dec 5, 2024
Comment on lines
+19
to
+22
| - width: image.$.style.width && parseInt( image.$.style.width ) || image.getAttribute( 'width' ) || '150px', | ||
| - height: image.$.style.height && parseInt( image.$.style.height ) || image.getAttribute( 'height' ) || 'auto', | ||
| + width: image.$.style.width && parseInt( image.$.style.width ) || image.getAttribute( 'width' ) || '', | ||
| + height: image.$.style.height && parseInt( image.$.style.height ) || image.getAttribute( 'height' ) || '', |
There was a problem hiding this comment.
There is a line deleted in patch 20 that we're not reverting,
'.cke_widget_wrapper.cke_widget_image {width: 100%;}'Is this intentional?
If it is, this PR is fine as it is. If it is a full revert, can we just delete patch 20 and rebuild?
There was a problem hiding this comment.
Yes, because that line was added in patch 17... then removed in patch 20 by this new solution than I'm also reverting now.
Basically I'm getting rid of our tries to get this behavior inside liferay-ckeditor. We'll do it in portal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This new patch (#21) is basically reverting our previous tries (#20, #17) to render images with no width.
After a deeper analysis, we've seen none of these solutions is working 100% and this issue should be better handled inside Liferay Portal, to be more exact, within itemselector plugin.
Once this pr gets merged, I'll release a new liferay-ckeditor version, and then I'll send a pull request to liferay-portal upgrade such version and including the fix within itemselector plugin.
Thanks.
Regards.