-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(npm-scripts): add jest mock for createRange and createContextualFragment #234
Conversation
e2388b7
to
09278a3
Compare
We generally consider lint suppressions to be a "smell", because they can cover up real problems. So, use an alternative approach instead, telling ESLint that this file runs in a "browser" context (where `document` is defined).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg2m. I'm going to apply some small tweaks on top and merge as soon as I see it green.
So I didn't test this but I assume you did @bryceosterhaus 😂 — there are any number of different ways If you want to try cutting a release, the CONTRIBUTING.md should be up-to-date. Things have probably changed a bit since the last time you did it, but not too much. It's basically going to boil down to:
|
@wincent are there any docs for updating npm-scripts in portal? |
No because it is pretty straight forward; from
I can add this to the contributing doc though. The only tricky part is that sometimes Yarn requires a bit of coaxing to deduplicate the lockfile, as noted here:
I usually start at the first and go down that list until I get the result I want. It used to be that step 1 was always enough; but lately I've found I have to do 2 quite often as well. I might heav had to do 3 once, and I've never done 4. |
Docs added here. |
This PR has a handful of failing unit tests due to createRange not existing in js-dom. Rather than add a setupfile for each module to include this, I figured its best to have as a global mock.
liferay-frontend/liferay-portal#468