Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debridge DLN Facet (Version 1.0.0) #827

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Debridge DLN Facet (Version 1.0.0) #827

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
07219e2
Move DeBridgeDLNFacet from archive
ezynda3 Oct 8, 2024
69a5bae
Move docs from archive and update README
ezynda3 Oct 8, 2024
a1038fa
Merge branch 'main' into debridge-dln
ezynda3 Oct 9, 2024
091cf24
Merge branch 'main' of github.com:lifinance/contracts into debridge-dln
ezynda3 Oct 9, 2024
6fc5c78
improve code coverage
ezynda3 Oct 9, 2024
72c23ca
improve code coverage
ezynda3 Oct 9, 2024
7167772
Merge branch 'debridge-dln' of github.com:lifinance/contracts into de…
ezynda3 Oct 9, 2024
11225de
Merge branch 'main' of github.com:lifinance/contracts into debridge-dln
ezynda3 Oct 10, 2024
975f85e
Fix opbnb
ezynda3 Oct 10, 2024
ac123a3
Update variable naming
ezynda3 Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions deployments/_deployments_log_file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20591,12 +20591,12 @@
"staging": {
"1.0.0": [
{
"ADDRESS": "0xE500dED7b9C9f1020870B7a6Db076Dbd892C0fea",
"ADDRESS": "0xaF5001e4cd39B3515B244B18A88DD5b2fE65c5cD",
"OPTIMIZER_RUNS": "1000000",
"TIMESTAMP": "2024-02-22 14:29:31",
"TIMESTAMP": "2024-10-08 14:03:01",
"CONSTRUCTOR_ARGS": "0x000000000000000000000000ef4fb24ad0916217251f553c0596f8edc630eb66",
"SALT": "",
"VERIFIED": "true"
"VERIFIED": "false"
}
]
}
Expand All @@ -20605,9 +20605,9 @@
"staging": {
"1.0.0": [
{
"ADDRESS": "0xE500dED7b9C9f1020870B7a6Db076Dbd892C0fea",
"ADDRESS": "0xaF5001e4cd39B3515B244B18A88DD5b2fE65c5cD",
"OPTIMIZER_RUNS": "1000000",
"TIMESTAMP": "2024-02-22 15:43:42",
"TIMESTAMP": "2024-10-08 13:59:43",
Comment on lines +20608 to +20610
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Duplicate deployment entries detected for the contract address "0xaF5001e4cd39B3515B244B18A88DD5b2fE65c5cD".

Multiple entries exist for this address with differing verification statuses. This may lead to confusion and inconsistencies in the deployment logs.

Please address the following:

  • Remove or consolidate duplicate entries for the same contract address to ensure clarity.
  • Verify the correct "VERIFIED" status is reflected for each contract deployment.
🔗 Analysis chain

Clarify the purpose of duplicate deployment entries.

This hunk appears to be a duplicate entry for the same contract address (0xaF5001e4cd39B3515B244B18A88DD5b2fE65c5cD) with a slightly earlier timestamp (2024-10-08 13:59:43) compared to the previous entry. The main difference is that this entry shows the contract as verified (VERIFIED: "true").

Please address the following:

  1. Clarify the purpose of having two entries for the same contract address. Is this intended to show the verification process?
  2. If these are meant to be separate deployments, consider using a different versioning scheme or naming convention to distinguish them.
  3. Ensure that only the most up-to-date and accurate information is retained in the deployment log.

To check for other potential duplicate entries, run the following script:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for duplicate contract addresses in deployment logs

# Test: Search for duplicate contract addresses
echo "Checking for duplicate contract addresses:"
rg --json -o '"ADDRESS": "[^"]+"' deployments/_deployments_log_file.json | 
  jq -r '.data.submatches[0].match' | 
  sort | 
  uniq -d

Length of output: 23714

"CONSTRUCTOR_ARGS": "0x000000000000000000000000ef4fb24ad0916217251f553c0596f8edc630eb66",
"SALT": "",
"VERIFIED": "true"
Expand Down
10 changes: 7 additions & 3 deletions deployments/arbitrum.diamond.staging.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"LiFiDiamond": {
"Facets": {
"0x9a0988b17D4419807DfC8E8fd2182A21eabB1361": {
"Name": "EmergencyPauseFacet",
"Version": "1.0.0"
},
"0xB2A8517734CDf985d53F303A1f7759A34fdC772F": {
"Name": "DiamondCutFacet",
"Version": "1.0.0"
Expand Down Expand Up @@ -133,8 +137,8 @@
"Name": "",
"Version": ""
},
"0x9a0988b17D4419807DfC8E8fd2182A21eabB1361": {
"Name": "EmergencyPauseFacet",
"0xaF5001e4cd39B3515B244B18A88DD5b2fE65c5cD": {
"Name": "DeBridgeDlnFacet",
"Version": "1.0.0"
}
},
Expand All @@ -152,4 +156,4 @@
"TokenWrapper": "0xF63b27AE2Dc887b88f82E2Cc597d07fBB2E78E70"
}
}
}
}
2 changes: 1 addition & 1 deletion deployments/arbitrum.staging.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"ServiceFeeCollector": "0x9cc3164f01ED3796Fdf7Da538484D634608D2203",
"WormholeFacet": "0x7260Fd3F8D0bEb06fF5935C6eadE9f406107c270",
"SymbiosisFacet": "0x21571D628B0bCBeb954D5933A604eCac35bAF2c7",
"DeBridgeDlnFacet": "0xE500dED7b9C9f1020870B7a6Db076Dbd892C0fea",
"DeBridgeDlnFacet": "0xaF5001e4cd39B3515B244B18A88DD5b2fE65c5cD",
"MayanFacet": "0xd596C903d78870786c5DB0E448ce7F87A65A0daD",
"StandardizedCallFacet": "0xA7ffe57ee70Ac4998e9E9fC6f17341173E081A8f",
"GenericSwapFacetV3": "0xFf6Fa203573Baaaa4AE375EB7ac2819d539e16FF",
Expand Down
10 changes: 7 additions & 3 deletions deployments/polygon.diamond.staging.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,16 @@
"0x21571D628B0bCBeb954D5933A604eCac35bAF2c7": {
"Name": "SymbiosisFacet",
"Version": "1.0.0"
},
"0xaF5001e4cd39B3515B244B18A88DD5b2fE65c5cD": {
"Name": "DeBridgeDlnFacet",
"Version": "1.0.0"
}
},
"Periphery": {
"ERC20Proxy": "0xF6d5cf7a12d89BC0fD34E27d2237875b564A6ADf",
"ERC20Proxy": "",
"Executor": "0x23f882bA2fa54A358d8599465EB471f58Cc26751",
"FeeCollector": "0x7F8E9bEBd1Dea263A36a6916B99bd84405B9654a",
"FeeCollector": "",
"GasRebateDistributor": "",
"LiFiDEXAggregator": "",
"LiFuelFeeCollector": "0x94EA56D8049e93E0308B9c7d1418Baf6A7C68280",
Expand All @@ -128,4 +132,4 @@
"TokenWrapper": "0xF63b27AE2Dc887b88f82E2Cc597d07fBB2E78E70"
}
}
}
}
4 changes: 2 additions & 2 deletions deployments/polygon.staging.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"ServiceFeeCollector": "0x9cc3164f01ED3796Fdf7Da538484D634608D2203",
"LiFuelFeeCollector": "0x94EA56D8049e93E0308B9c7d1418Baf6A7C68280",
"AcrossFacetPacked": "0x7A3770a9504924d99D38BBba4F0116B756393Eb3",
"DeBridgeDlnFacet": "0xE500dED7b9C9f1020870B7a6Db076Dbd892C0fea",
"DeBridgeDlnFacet": "0xaF5001e4cd39B3515B244B18A88DD5b2fE65c5cD",
"AmarokFacetPacked": "0x0aB252E7b5167Be2aC7841Bdaf1689E1a475ceE7",
"TokenWrapper": "0xF63b27AE2Dc887b88f82E2Cc597d07fBB2E78E70",
"GasRebateDistributor": "0x3116B8F099D7eFA6e24f39F80146Aac423365EB9",
Expand All @@ -46,4 +46,4 @@
"CelerCircleBridgeFacet": "0x371E073f6A09DCBEE1D2Ac56E940F878a0Ba9DAE",
"HopFacetOptimized": "0xf82135385765f1324257ffF74489F16382EBBb8A",
"SymbiosisFacet": "0x21571D628B0bCBeb954D5933A604eCac35bAF2c7"
}
}
0 archive/docs/DeBridgeDlnFacet.md → docs/DeBridgeDlnFacet.md
View file
Open in desktop
File renamed without changes.
6 changes: 1 addition & 5 deletions docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
- [CBridge Facet](./CBridgeFacet.md)
- [Celer Circle Bridge Facet](./CelerCircleBridgeFacet.md)
- [Circle Bridge Facet](./CircleBridgeFacet.md)
- [DeBridge Facet](./DeBridgeFacet.md)
- [DeBridge DLN Facet](/docs/DeBridgeDlnFacet.md)
- [DEX Manager Facet](./DexManagerFacet.md)
- [DiamondCut Facet](./DiamondCutFacet.md)
- [DiamondLoupe Facet](./DiamondLoupeFacet.md)
Expand All @@ -21,19 +21,15 @@
- [Hop Facet Packed](./HopFacetPacked.md)
- [Hyphen Facet](./HyphenFacet.md)
- [LIFuel Facet](./LIFuelFacet.md)
- [MakerTeleport Facet](./MakerTeleportFacet.md)
- [Mayan Facet](./MayanFacet.md)
- [Multichain Facet](./MultichainFacet.md)
- [OmniBridge Facet](./OmniBridgeFacet.md)
- [Optimism Bridge Facet](./OptimismBridgeFacet.md)
- [Periphery Registry Facet](./PeripheryRegistryFacet.md)
- [Polygon Bridge Facet](./PolygonBridgeFacet.md)
- [Ronin Bridge Facet](./RoninBridgeFacet.md)
- [Squid Facet](./SquidFacet.md)
- [Standardized Call Facet](./StandardizedCallFacet.md)
- [Stargate Facet](./StargateFacet.md)
- [Stargate FacetV2](./StargateFacetV2.md)
- [Synapse Bridge Facet](./SynapseBridgeFacet.md)
- [ThorSwap Facet](./ThorSwapFacet.md)
- [Withdraw Facet](./WithdrawFacet.md)

Expand Down
2 changes: 1 addition & 1 deletion script/demoScripts/demoDLN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import deployments from '../../deployments/mainnet.staging.json'
import deployments from '../../deployments/arbitrum.staging.json'
import {
ezynda3 marked this conversation as resolved.
Show resolved Hide resolved
DeBridgeDlnFacet__factory,
ILiFi,
Expand Down
0 archive/scripts/DeployDeBridgeDlnFacet.s.sol → ...eploy/facets/DeployDeBridgeDlnFacet.s.sol
View file
Open in desktop
File renamed without changes.
0 archive/scripts/UpdateDeBridgeDlnFacet.s.sol → ...eploy/facets/UpdateDeBridgeDlnFacet.s.sol
View file
Open in desktop
File renamed without changes.
0 archive/src/DeBridgeDlnFacet.sol → src/Facets/DeBridgeDlnFacet.sol
View file
Open in desktop
File renamed without changes.
0 archive/test/DeBridgeDlnFacet.t.sol → test/solidity/Facets/DeBridgeDlnFacet.t.sol
View file
Open in desktop
File renamed without changes.
Loading