Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the git identity before patching #150

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

mrexodia
Copy link
Contributor

@mrexodia mrexodia commented Dec 5, 2022

When using sleigh as a dependency it fails in the GitHub Actions pipeline with an error like this:

HEAD is now at 9c724c1a Merge remote-tracking branch 'origin/GP-2355_AARCH64_thunk_pattern' into patch
[2/9] Performing update step for 'ghidrasource-populate'
[3/9] Performing patch step for 'ghidrasource-populate'

Committer identity unknown

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <runner@xxx>) not allowed
FAILED: ghidrasource-populate-prefix/src/ghidrasource-populate-stamp/ghidrasource-populate-patch

For now I just set it the same as in main.yml, but let me know if there should be some logic there. Perhaps it should only set the identity if there is none set globally or something...

@tetsuo-cpp
Copy link
Contributor

For now I just set it the same as in main.yml, but let me know if there should be some logic there. Perhaps it should only set the identity if there is none set globally or something...

I don't see any harm in doing it unconditionally. What do you think @ekilmer?

Copy link
Contributor

@ekilmer ekilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

I have also been setting this in my CI yaml, but I've also run into this issue with Dockerfiles and other temporary build environments that don't have it set up.

I also agree that setting it unconditionally won't hurt or change anything much.

@ekilmer ekilmer merged commit f12acdf into lifting-bits:master Dec 5, 2022
ekilmer added a commit that referenced this pull request Dec 15, 2022
* master:
  Update Ghidra HEAD to commit db932d222 (#151)
  Set the git identity before patching (#150)
  Update Ghidra HEAD to commit d182ba8ed (#149)
  Update Ghidra HEAD to commit 522bda39e (#148)
  build(deps): bump softprops/action-gh-release from 0.1.14 to 0.1.15 (#147)
  Update Ghidra HEAD to commit 75ddd08bb (#146)
  Update to Ghidra 10.2.2
  CI: Compile with position independent code
  CI: Fix cache env variables
  Remove deprecated CI functionality
  Update to Ghidra 10.2.1
  Update Ghidra HEAD to commit 97097daa6 (#145)
  Update Ghidra HEAD to commit 69b07161b (#144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants