Pass username and instanceHost in UserData with the JWT #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JWT The app mostly just passes the JWT token around, which is ok for auth but is not ok for identification. This modifies a lot of files but all it really does is refactors the controllers to use UserData instead of just the JWT token directly. This will allow us to identify which user the request is being made for, rather than just blindly passing auth data. This will be more useful in later commits.
zachatrocity
approved these changes
Jul 4, 2023
jcgurango
added a commit
that referenced
this pull request
Jul 4, 2023
…riginating instance (#254) This adds a new menu item which appears under the "..." menu of a community called "View on another instance".  This pops up a list of accounts for you to choose from. The "Subscribe" button, when viewing anonymously, also pops this up:  This then executes a ResolveObject call to retrieve the community:  Before showing you the community, in the other instance. Denoted by the "(via instance)" text in the name of the community.  You can then subscribe directly from here, or if some posts are loaded you can even comment or vote directly. Dependent on #261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app mostly just passes the JWT token around, which is ok for auth but is not ok for identification. This modifies a lot of files but all it really does is refactors the controllers to use UserData instead of just the JWT token directly. This will allow us to identify which user the request is being made for, rather than just blindly passing auth data. This will be more useful in later commits.