Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu item to view comment or post in a specific instance #277

Conversation

jcgurango
Copy link
Collaborator

@jcgurango jcgurango commented Jul 5, 2023

Adds a new menu item to view posts/comments in another instance so you can interact with them.
view-federated-post-demo-down.webm
view-federated-comment-demo-down.webm

Copy link
Collaborator

@shocklateboy92 shocklateboy92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a skim through this, and nothing jumped out at me, so I guess LGTM.

}

if (snapshot.hasError) {
message = 'Error: ${snapshot.error}';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, do we localize error messages?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, no. At least not all of them. Even the "You are not logged in there" message isn't localized. I think maybe Lemmur was made before the l10n library could do parameters? Or they just didn't know?

@shocklateboy92 shocklateboy92 merged commit b2791b2 into liftoff-app:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants