Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A draft UI change for discussion #471

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

mykdavies
Copy link
Contributor

I was thinking about the discussion we had yesterday on GitHub about account switching, and wondered if this makes sense as an approach.

Thoughts anyone?

@mykdavies
Copy link
Contributor Author

mykdavies commented Aug 3, 2023

At the heart it just adds the user icon to the top left:
Screenshot 2023-08-03 at 22 41 59

Clicking on it allows you to change account:

Screenshot 2023-08-03 at 23 02 40

There's also a bit of juggling of content in the app bar going on, but that's less important.
It's not really working fully at the moment, but I wanted to share it for people to have a think about whether it would be a helpful direction to head in.

@mykdavies mykdavies changed the title First draft for review A draft UI change for discussion Aug 3, 2023
@zachatrocity
Copy link
Collaborator

I really like this. The swipe idea would be nice. Or I was even thinking we need a top action sheet widget. Could be useful for the 3dot menu up there or useful for this so the user doesn't have to juggle their phone around to select.

@mykdavies
Copy link
Contributor Author

mykdavies commented Aug 4, 2023

Tapping now takes you to your inbox, and a long press will bring up the account switcher. That makes Lasath's swipe down action attractive as an additional gesture, so I'll probably have a look at that soon.

This approach removes the need for the bell icon on the appbar which frees up space for longer instance names on home tab:
Screenshot 2023-08-04 at 17 55 53

Also means the notification stays visible even if you're deep in a thread (not tested how reactive it actually is, may not update until you change screen?):
Screenshot 2023-08-04 at 17 50 50.

I've also experimented here with making the reminder post title in the appbar smaller so that you can actually read most titles without a fadeout.

There's some screens where I've not added it as I'm worried it may make things confusing. I've also started thinking about blocking account changing this way on some screens in case it leads to chaos...

I'm going to install this on my phone and have a play with it over the next day and see how it feels.

Comments would be welcome again.

@mykdavies
Copy link
Contributor Author

So this icon now supports the following actions:

  • tap = view inbox
  • double tap = view account page
  • long press = choose account to switch to
  • swipe up/down = switch to next account

Any more actions to add? 😄

Two issues still:

  • it's currently loading the user image from the instance rather than a local cache.
  • I'm not not if adding onAccountChange() is the best way of dealing with propagating account changes - is there a better approach?

@zachatrocity
Copy link
Collaborator

Looks really good. Minor nit, the left margin seems too small. It should match the 3 dot Menu on the right side

@mykdavies
Copy link
Contributor Author

Hi @zachatrocity, thanks for checking it out. I think I moved the avi away from the edge in 748dd66 as I saw how ridiculously close it was to the edge of the screen.

I've had it on my phone over the weekend, and really like the changes (of course :-), but as I've used it, I've found that it gets very snarled up in a lot of the complexity we have around account management. I put a comment up on Matrix in reply to @jcgurango's nice feedback which goes into my concerns a little more. I think it's worth doing, but we need to be sure what it is we're actually doing first...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants