Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI by using fixed flutter version 3.10.6 #518

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Nithanim
Copy link
Contributor

Building the pull requests by the CI stopped working some time ago. Presumably, the specified flutter channel "stable" got updated and is now incompatible which lets every build fail. Pinning the flutter version to 3.10.6 for the CI fixes that. Note that the version was chosen by best guess that worked at least somewhat locally. (I have yet to get a build finished locally.) It might not be the version that was used "originally".

@zachatrocity
Copy link
Collaborator

Thanks for doing this. I had tried awhile back and was getting other failures. Approved for run we'll see what happens

Copy link
Collaborator

@zachatrocity zachatrocity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@zachatrocity zachatrocity merged commit d7fdeb0 into liftoff-app:master Nov 27, 2023
5 checks passed
@Nithanim
Copy link
Contributor Author

Perfect, thank you!

Lgtm

These are normally the last words before everything goes downhill :P

Thanks for doing this. I had tried awhile back and was getting other failures.

No problem! I just hoped that I would get anything running. At least I tried something to work towards this app not breaking with lemmy 0.19.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants