-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate from multiple snip labels #22
Aggregate from multiple snip labels #22
Conversation
Also adds tests for symbols after snippet markers.
Example: @@ snip [Code.scala](../scala/Code.scala) { #imports #functions } Fixes lightbend#21
@@ -1 +1,3 @@ | |||
@@ snip [multiple snippet](../../test/scala/Multiple.scala) { #multiple } | |||
|
|||
@@ snip [comma separated snippet](../../test/scala/Multiple.scala) { #parseint-imports #parseint-def } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test for the case that has type=conf
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Let me know if you want me to squash it.
Thanks a lot for adding this feature! |
Thanks a lot for helping out on this front @jonas! |
LGTM |
@jonas Do you want me to cut a release out as is, or are you working on more a PR for the other issue? |
@eed3si9n Two potential things would help a lot converting the Akka HTTP docs to Paradox at this point.
The first one can be considered nice-to-have and might even be out of scope for Paradox, however, the latter would remove the need to mess up the API code with lots of markers or extract the snippets via an SBT task before running Paradox. |
@jonas Could you open new Github issues to discuss them? |
@eed3si9n Opened related tickets. When you have time please cut a release so this won't block akka/akka-http#1 |
@jonas Paradox 0.2.2 is pushed to Sonatype on its way to Maven Central. |
No description provided.