Properties front matter #28
Conversation
| The `out` property allows to rename the target name of the current file. | ||
| And the `layout` allows to specify the layout we want to be used for this particular page, the layouts are placed by default in the `target/paradox/theme` folder: | ||
|
|
||
| ```scala |
There was a problem hiding this comment.
Yes of course, my bad!
|
|
||
| /** | ||
| * Page template writer. | ||
| */ | ||
| class PageTemplate(directory: File, startDelimiter: Char = '$', stopDelimiter: Char = '$', name: String = "page") { | ||
| class PageTemplate(directory: File, name: String = PageTemplate.DefaultName, startDelimiter: Char = '$', stopDelimiter: Char = '$') { |
There was a problem hiding this comment.
Could you add test for layout feature?
There was a problem hiding this comment.
Here's what I used for testing https://github.com/eed3si9n/tech-hub-landing-page/tree/wip/layout_check, which didn't work for me.
There was a problem hiding this comment.
After fixing the typo in my test, it seems to be working now. We should still add tests though.
| val p = new java.util.Properties | ||
| for (s <- str) { | ||
| val q = new java.util.Properties | ||
| q.load(new StringReader(s)) |
There was a problem hiding this comment.
Given that Typesafe Config is the most awesome config reader on the JVM, it would be interesting to eventually switch to that for managing properties in Paradox and allow more flexible types and loading of properties.
There was a problem hiding this comment.
Yes, would be really nice to use Typesafe Config. There could be some inspiration in the way Stefan's Ornate uses Config: https://github.com/szeiger/ornate
|
I'm going to merge as is, and we can add the HOCON (Typesafe Config) support later. |
Global support for properties at page level.
For now, only support for "out" and "layout" properties.
resolve #15