Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow @ref in index; introduce @link #313

Merged
merged 4 commits into from
May 22, 2019
Merged

Allow @ref in index; introduce @link #313

merged 4 commits into from
May 22, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented May 22, 2019

Changed and added directives:

  • @ref is now allowed in @@@index sections, which is equivalent to usual markdown [..](..)
  • @link may be used as an alternative to markdown's [..](..) with the additional feature to add an open=new attribute to make the link open in a new browser

This is some groundwork to implement #286 which may allow using @link in @@@index sections.

2m
2m approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ennru ennru added this to the 0.5.5 milestone May 22, 2019
@ennru ennru merged commit 1e99bfa into lightbend:master May 22, 2019
@ennru ennru deleted the external-links-in-index branch May 22, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2m 2m 2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.5
Development

Successfully merging this pull request may close these issues.
2 participants
@ennru @2m