-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #43: Add @javadoc directive #52
Conversation
I find linking directly to the javadoc class HTML to give a terrible user experience, because then they don't have the navigation from the frames that is very often needed. In Lagom and Play, we always link to https://github.com/lagom/lagom/blob/master/project/Doc.scala#L60 |
FYI note that the frames are gone, at least in the official Scala API docs: http://www.scala-lang.org/api/current/scala/Int.html |
Yep but this is for javadocs, not scaladocs. |
OK, I will update the PR and rebase to add support for referenced source definitions. |
b5fc3d2
to
9431beb
Compare
Which allows to modify individual URL components.
9431beb
to
9d7b3c4
Compare
case class Url(base: URI) { | ||
def withEndingSlash = base.getPath match { | ||
case path if path.endsWith("/index.html") => this | ||
case path => copy(path = path + "/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main goal here is to avoid links that will automatically redirect, yet allow to spell them out with .../index.html
if so desired.
I believe I've addressed all comments.
|
No description provided.