Skip to content

Commit

Permalink
CONTRIBUTING.md: modern feature bit assignment.
Browse files Browse the repository at this point in the history
1. Put it in the PR title so everyone can see.
2. Deploy with +100 while it's still unratified, in case it changes.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
  • Loading branch information
rustyrussell committed Sep 11, 2023
1 parent 6e85df4 commit 58473d0
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ escape into the wild).
also they can be used to find appropriate peers.

Feature bits are always assigned in pairs, even if it doesn't make sense
for them to ever be compulsory.
for them to ever be compulsory. The feature bit is self-assigned in the
title of the PR, to make it easier for others to self-assign. Until the PR
is merged into the spec, experimental implementations should use the proposed
feature bit +100; they can accept both feature bits once it is merged (if
the protocol does not change!).

Almost every spec change should have a feature bit associated; in the past
we have grouped feature bits, then we couldn't disable a single feature
Expand Down

0 comments on commit 58473d0

Please sign in to comment.