Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gossip: delay considering a channel edge deleted for 12-blocks #1004

Merged
merged 1 commit into from
Aug 15, 2022
Merged

gossip: delay considering a channel edge deleted for 12-blocks #1004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion 07-routing-gossip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ The receiving node:
- otherwise:
- SHOULD store this `channel_announcement`.
- once its funding output has been spent OR reorganized out:
- SHOULD forget a channel.
- SHOULD forget a channel after a 12-block delay.

### Rationale

Expand All @@ -249,6 +249,10 @@ optional) features will have _odd_ feature bits, while incompatible features
will have _even_ feature bits
(["It's OK to be odd!"](00-introduction.md#glossary-and-terminology-guide)).

A delay of 12-blocks is used when forgetting a channel on funding output spend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a hard time parsing "channel on funding output spend". What is exactly meant by that?

Also, nit: s/12-blocks/12 blocks/

Copy link
Collaborator Author

@niftynei niftynei Jun 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See L226:

  - once its funding output has been spent OR reorganized out:

as to permit a new `channel_announcement` to propagate which indicates this
channel was spliced.

## The `node_announcement` Message

This gossip message allows a node to indicate extra data associated with it, in
Expand Down