Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOLT 3: fix definition of flip(B) in P. #779

Merged
merged 1 commit into from
Jul 7, 2020
Merged

BOLT 3: fix definition of flip(B) in P. #779

merged 1 commit into from
Jul 7, 2020

Commits on Jul 6, 2020

  1. BOLT 3: fix definition of flip(B) in P. 

    It turns out everyone does `P[B / 8] ^= (1 << (P % 8))`,
which is not what the spec says to do (it implies you
would treat P as a bitstring numbered 255 to 0).

See this stackoverflow question:
	https://stackoverflow.com/questions/49928131/lightning-secret-generation-from-seed

Reported-by: Janus Troelsen @ysangkok (on Twitter)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    a884731 View commit details
    Browse the repository at this point in the history