New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOLT 2: upgrade protocol on reestablish #868

Closed

rustyrussell wants to merge 3 commits into lightning:master from rustyrussell:guilt/upgrade_protocol

Collaborator

rustyrussell commented May 7, 2021 •

edited

Loading

This is the simplest upgrade mechanism I could come up with. It's ready for option_anchors_zero_fee_htlc_tx, too.

Note the reason it's on reconnect: whatever we do, we need to handle reconnect during an upgrade attempt, which meant some kind of fallback "where were we up to?" at that point. Simplest to make that "fallback" technique the only technique.

And in practice we don't upgrade software without reconnecting anyway.

rustyrussell requested a review from t-bast

May 7, 2021 03:04

rustyrussell force-pushed the guilt/upgrade_protocol branch 3 times, most recently from fff174e to 494e54c Compare

May 7, 2021 04:34

t-bast mentioned this pull request

Lightning Specification Meeting 2021/05/10 #870

Closed

9 tasks

rustyrussell force-pushed the guilt/upgrade_protocol branch from 494e54c to 1faa642 Compare

May 10, 2021 20:09

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channel: import upgrade spec.

9049ccf

See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channeld: handle upgrade match.

ff41c98

We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell mentioned this pull request

EXPERIMENTAL: channel upgrade support ElementsProject/lightning#4532

Merged

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channel: import upgrade spec.

2c6729c

See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channeld: handle upgrade match.

a5c0367

We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channeld: handle upgrade match.

d637c07

We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell force-pushed the guilt/upgrade_protocol branch from b8f3a95 to d5c9e9b Compare

May 24, 2021 04:59

cdecker pushed a commit to rustyrussell/lightning that referenced this pull request


          channel: import upgrade spec.

58792f4

See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

cdecker pushed a commit to rustyrussell/lightning that referenced this pull request


          channeld: handle upgrade match.

942875a

We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

cdecker pushed a commit to rustyrussell/lightning that referenced this pull request


          channel: import upgrade spec.

a6da78d

See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

cdecker pushed a commit to rustyrussell/lightning that referenced this pull request


          channeld: handle upgrade match.

7ee6772

We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channel: import upgrade spec.

5be0d20

See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channeld: handle upgrade match.

be81073

We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channeld: handle upgrade match.

bc299ce

We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channel: import upgrade spec.

3504aad

See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channeld: handle upgrade match.

We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channel: import upgrade spec.

a4153e2

See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channeld: handle upgrade match.

763aadb

We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channel: import upgrade spec.

3d8c4a1

See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channeld: handle upgrade match.

60b5433

We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channel: import upgrade spec.

4796f4a

See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channeld: handle upgrade match.

c358509

We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channel: import upgrade spec.

436197f

See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request


          channeld: handle upgrade match.

640e3a1

We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>


          BOLT 1: define what offered and negotiated mean.

084402f

i.e. it was present in the init feature bits.  We use this in several places, but assume everyone knows what it means.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell force-pushed the guilt/upgrade_protocol branch from 7be9947 to 084402f Compare

August 30, 2023 02:15

Collaborator Author

rustyrussell commented Aug 30, 2023

Rebased, and added an explicit feature bit. As a bonus I threw in a commit which defined what "negotiated" and "offered" mean for features!

t-bast mentioned this pull request

Lightning Specification Meeting 2023/09/25 #1114

Closed

24 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2023/10/23 #1115

Closed

22 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2023/11/06 #1116

Closed

20 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2023/11/20 #1118

Closed

20 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2023/12/04 #1122

Closed

20 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2023/12/18 #1124

Closed

20 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/01/15 #1127

Closed

21 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/01/29 #1129

Closed

19 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/02/12 #1134

Closed

22 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/02/26 #1142

Closed

21 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/03/11 #1146

Closed

21 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/03/25 #1150

Closed

21 tasks

Roasbeef mentioned this pull request

Lightning Specification Meeting 2024/04/08 #1152

Closed

21 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/04/22 #1155

Closed

22 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/05/06 #1161

Closed

25 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/05/20 #1164

Closed

23 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/06/03 #1167

Closed

23 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/06/17 #1172

Closed

22 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/07/01 #1175

Closed

23 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/07/15 #1183

Closed

22 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/07/29 #1185

Closed

23 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/08/12 #1187

Closed

21 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/08/26 #1191

Closed

20 tasks

t-bast mentioned this pull request

Lightning Specification Meeting 2024/09/09 #1195

Closed

20 tasks

Collaborator

t-bast commented Sep 18, 2024

I believe this is superseded by #1117, do we have consensus on that?

t-bast mentioned this pull request

Lightning Specification Meeting 2024/11/04 #1206

Open

20 tasks

rustyrussell closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet