Div compatibility fix #16 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.) get_url returns the dict after extracting the json attribute therefore this fails in the UserWallet class. 2.) /api/v1/payments/decode expects the body as json
|
Thank you. let me see if i can get this merged in the morning :) |
|
Hey Great. It is not so urgent. And sorry for the spam on VIDA and Twitter. Just saw the message now.Lg FelixAm 24.05.23 um 06:20 schrieb Bitkarrot
Von: "Bitkarrot" ***@***.***>Datum: 24. Mai 2023An: "lightningames/pylnbits" ***@***.***>Cc: "Felix Frei" ***@***.***>,"Author" ***@***.***>Betreff: Re: [lightningames/pylnbits] Div compatibility fix #16 (PR #17)
Thank you. let me see if i can get this merged in the morning :)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Removed some variable renaming
bitkarrot
approved these changes
May 25, 2023
No problem :) I replied to your message on twitter. Not sure about Vida, i don't think i've used that in a long time; hope the experience has improved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.) get_url returns the dict after extracting the json attribute therefore this fails in the UserWallet class.
2.) /api/v1/payments/decode expects the body as json
Tested with LNbits version: 0.10.6