Fix backup/README.md dead link #479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebase |
Fix a dead link to "info about backup solutions"
chrisguida
previously requested changes
Feb 12, 2024
backup/README.md
Outdated
| @@ -6,7 +6,7 @@ This plugin will maintain clean database backups to another location. It uses | |||
| the `db_write` hook to make sure to always have a backup that is not missing any | |||
| state updates and is not potentially harmful. | |||
|
|
|||
| Related info about backup solutions: https://github.com/ElementsProject/lightning/blob/master/doc/BACKUP.md | |||
| Related info about backup solutions: https://github.com/ElementsProject/lightning/blob/master/doc/beginners-guide/backup-and-recovery.md | |||
There was a problem hiding this comment.
This link appears to be broken as well
mergify
bot
dismissed
chrisguida’s stale review
Pull request has been modified.
|
Can you clean up the commit history here? For some reason there are 5 commits, there needs to be just 1 commit with your change. I tried to merge master into your branch but it did not fix the problem, sorry. |
chrisguida
requested changes
Feb 21, 2024
|
Contributor does not allow maintainers to amend the PR. As such we need them to rebase in order to be merged. If the author does not, I will just cherry-pick the one useful commit onto a fixup PR later. |
|
Closing in favor of #531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a dead link to "info about backup solutions"