Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unmaintained nostrify #486

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

daywalker90
Copy link
Contributor

According to the plugins README this plugin is unmaintained/obsolete. It's also failing it's tests.

@chrisguida
Copy link
Collaborator

Looks like nostr-control is the replacement? https://github.com/joelklabo/nostr-control

@joelklabo do you have any comment?

@joelklabo
Copy link
Contributor

Yeah, that's right. To be honest I haven't tested either in a while though.

@daywalker90 daywalker90 force-pushed the remove-nostrify branch 2 times, most recently from 85087a5 to 08c2667 Compare February 6, 2024 20:42
@cdecker
Copy link
Contributor

cdecker commented Feb 7, 2024

Got it 👍

@chrisguida
Copy link
Collaborator

chrisguida commented Feb 7, 2024

@cdecker do we want to put this in "archived" or just remove entirely like this?

Seems there are two categories of plugin demotion, temporary and permanent.

If @joelklabo says this one is permanently deprecated then it sounds like the correct move would be to remove it altogether?

In that case I think this is good to go.

@daywalker90 daywalker90 mentioned this pull request Feb 7, 2024
@cdecker
Copy link
Contributor

cdecker commented Feb 9, 2024

I'm happy with removing plugins if the former maintainer abandons them. The plugin code is still there, just not linked here. If it were a plugin whose code is in this repo I'd be tempted to move them to archived, just so the code remains readable, and potentil maintainers can come and re-activate the plugin's life again.

@cdecker cdecker merged commit 636f4e8 into lightningd:master Feb 9, 2024
12 checks passed
@chrisguida chrisguida mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants