-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust plugin CI support #487
Conversation
Very cool! let's merge this once #484 is in :) |
Are you sure? What about the problem of setting up the test environment (compiling/ python test dependencies etc.)? |
I guess what I meant to say is, let's hold off on merging this until #484 is in. Can you explain to me more what the problem is? Does this work for |
Half of the tests work, other half (grpc tests) do not because i'm missing the grpc code and before i figure out a way to get that in the CI i wanted to see on what solution we settle on regarding CI-test-setup. Right now i download the plugin binary from github see here. I don't know if you even want other plugins to compile during CI (would make it run really long if it's all rust plugins). Also i'm sure we should atleast look for a "requirements-dev.txt" or "requirements-tests.txt" or something so we can install python dependencies like we do for python plugins. (can't be "requirements.txt" because then the plugin gets detected as "python") |
Ok thanks for the details! Yeah I think maybe just adding a link to a binary may be the way to go for now until we have a more general solution. Plugin devs will assert that the binary they're using is indeed the binary that is built at the commit the submodule link points to. |
And yes, your suggestion of adding requirements-tests.txt or requirements-dev.txt is good. I'd be fine with either since I don't know which would be more standard. Perhaps @fmhoeger knows? |
915f509
to
988dd60
Compare
Is this replaced by #491? |
Pretty much for now, yes |
based on #484
This is a first draft with the goal to add support for rust plugins to be tested by the CI.
What i still like to add is a way to let these rust plugins run some "init" to setup the compiled binary or some other test dependencies, e.g. generate grpc bindings. Maybe look for a bash script "ci.sh" and run that?