Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust plugin CI support #487

Closed

Conversation

daywalker90
Copy link
Contributor

based on #484
This is a first draft with the goal to add support for rust plugins to be tested by the CI.

What i still like to add is a way to let these rust plugins run some "init" to setup the compiled binary or some other test dependencies, e.g. generate grpc bindings. Maybe look for a bash script "ci.sh" and run that?

@chrisguida
Copy link
Collaborator

Very cool! let's merge this once #484 is in :)

@daywalker90
Copy link
Contributor Author

Are you sure? What about the problem of setting up the test environment (compiling/ python test dependencies etc.)?

@chrisguida
Copy link
Collaborator

I guess what I meant to say is, let's hold off on merging this until #484 is in.

Can you explain to me more what the problem is? Does this work for holdinvoice?

@daywalker90
Copy link
Contributor Author

Half of the tests work, other half (grpc tests) do not because i'm missing the grpc code and before i figure out a way to get that in the CI i wanted to see on what solution we settle on regarding CI-test-setup.

Right now i download the plugin binary from github see here. I don't know if you even want other plugins to compile during CI (would make it run really long if it's all rust plugins).

Also i'm sure we should atleast look for a "requirements-dev.txt" or "requirements-tests.txt" or something so we can install python dependencies like we do for python plugins. (can't be "requirements.txt" because then the plugin gets detected as "python")

@chrisguida
Copy link
Collaborator

Ok thanks for the details!

Yeah I think maybe just adding a link to a binary may be the way to go for now until we have a more general solution.

Plugin devs will assert that the binary they're using is indeed the binary that is built at the commit the submodule link points to.

@chrisguida
Copy link
Collaborator

And yes, your suggestion of adding requirements-tests.txt or requirements-dev.txt is good.

I'd be fine with either since I don't know which would be more standard.

Perhaps @fmhoeger knows?

@daywalker90 daywalker90 force-pushed the rust-plugin-ci-support branch from 915f509 to 988dd60 Compare February 6, 2024 20:48
This was referenced Feb 7, 2024
@chrisguida
Copy link
Collaborator

Is this replaced by #491?

@daywalker90
Copy link
Contributor Author

Is this replaced by #491?

Pretty much for now, yes

@daywalker90 daywalker90 closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants