Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: fix workflow badge on readme page #489

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

m-schmoock
Copy link
Member

The old badge was pointing to the workflows name
https://github.com/lightningd/plugins/workflows/Integration%20Tests/badge.svg

However this seems to be always failing. Pointing to the workflow file main.yml, which only contains the one integration test workflow, gives a now green badge.

I'm not totally into the github internals, so maybe I'm mistaken on this one. Feedback appreciated.

The old badge was pointing to the workflows name
https://github.com/lightningd/plugins/workflows/Integration%20Tests/badge.svg

However this seems to be always failing. Pointing to the workflow file main.yml,
which only contains the one integration test workflow, gives a now green
badge.

I'm not totally into the github internals, so maybe I'm mistaken on
this one. Feedback appreciated.
@m-schmoock m-schmoock mentioned this pull request Feb 7, 2024
@cdecker
Copy link
Contributor

cdecker commented Feb 7, 2024

ACK 6a3a997

@cdecker cdecker merged commit b000c70 into lightningd:master Feb 7, 2024
12 checks passed
@m-schmoock m-schmoock deleted the fix/badge branch February 7, 2024 14:39
@chrisguida
Copy link
Collaborator

Thanks @m-schmoock! Looks snazzy now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants