Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feeadjuster: quick fix to get it back working due to listconfigs API changes #490

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

telelvis
Copy link
Contributor

@telelvis telelvis commented Feb 7, 2024

This PR gets feeadjuster up to date with recent changes in Listconfigs API where it now returns object instead of a list.
Makes plugin functional again.

Copy link
Collaborator

@chrisguida chrisguida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to move feeadjuster out of archived to get the CI to test it

@mergify mergify bot dismissed chrisguida’s stale review February 8, 2024 20:13

Pull request has been modified.

@telelvis
Copy link
Contributor Author

telelvis commented Feb 8, 2024

updated! please have a look.

@chrisguida chrisguida force-pushed the feeadjuster-fix-listconfigs branch from 50c8964 to 11273e0 Compare February 9, 2024 18:29
@chrisguida
Copy link
Collaborator

chrisguida commented Feb 9, 2024

ACK 11273e0

@chrisguida chrisguida merged commit 6a622fa into lightningd:master Feb 9, 2024
12 checks passed
@chrisguida
Copy link
Collaborator

feeadjuster lives! congrats 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants