Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add nightly workflow for CLN master; update main workflow to use latest CLN release #497

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

sip-21
Copy link
Collaborator

@sip-21 sip-21 commented Feb 16, 2024

  • Add a nightly workflow to test all (testable) plugins against the CLN master branch.
  • Update the main workflow to automatically use the latest CLN release to test against. In the context of a PR only those plugins are tested which had changes or were added to repository. When pushing to master all (testable) plugins will be tested.

@chrisguida
Copy link
Collaborator

Currently failing CI.

Also it seems beneficial to test all plugins before pushing to master, to make sure it will work before we merge.

@sip-21
Copy link
Collaborator Author

sip-21 commented Feb 16, 2024

Currently failing CI.

I see where the issue is.

Also it seems beneficial to test all plugins before pushing to master, to make sure it will work before we merge.

Yes, I did this for both workflows.
Will test all plugins again after the changes that still need to be made.

@sip-21 sip-21 marked this pull request as draft February 16, 2024 22:25
@sip-21 sip-21 force-pushed the ci-nightly-master-on-push-main branch from bceeaa1 to 1a240ad Compare February 17, 2024 22:47
@sip-21 sip-21 marked this pull request as ready for review February 17, 2024 22:49
@sip-21 sip-21 force-pushed the ci-nightly-master-on-push-main branch from 1a240ad to 8ced3b4 Compare February 18, 2024 16:20
@sip-21 sip-21 marked this pull request as draft February 19, 2024 17:34
@sip-21 sip-21 force-pushed the ci-nightly-master-on-push-main branch from 8ced3b4 to c455af8 Compare February 19, 2024 22:03
@sip-21 sip-21 marked this pull request as ready for review February 21, 2024 18:33
@sip-21 sip-21 force-pushed the ci-nightly-master-on-push-main branch from c455af8 to dc2c099 Compare February 24, 2024 17:09
@chrisguida
Copy link
Collaborator

ACK dc2c099

@daywalker90
Copy link
Contributor

I like the concept and it seems to be working

@cdecker
Copy link
Contributor

cdecker commented Mar 1, 2024

ACK dc2c099

@cdecker cdecker merged commit 286c952 into lightningd:master Mar 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants