Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Dockerfile, several plugins running #599

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

iorch
Copy link
Contributor

@iorch iorch commented Sep 26, 2024

@chrisguida
Copy link
Collaborator

Waiting on #584 as the mutinynet and testnet examples are dependent on mempool.space support

@ca-ruz
Copy link
Contributor

ca-ruz commented Sep 27, 2024

Hey, I tried it out and I ran into this error:

$ docker run -it --rm --network=host -v $HOME/.lightning:/root/.lightning -v $HOME/.bitcoin:/root/.bitcoin mycln-plugins --disable-plugin=bcli --log-level=debug --database-upgrade=true --sauron-api-endpoint https://blockstream.info/api/
Core-Lightning starting
2024-09-27T21:07:48.931Z INFO    lightningd: v24.02.2
2024-09-27T21:07:53.163Z DEBUG   plugin-manager: blacklist for bcli
2024-09-27T21:07:53.163Z INFO    plugin-manager: /usr/local/libexec/c-lightning/plugins/bcli: disabled via disable-plugin
2024-09-27T21:07:53.203Z DEBUG   plugin-manager: started(11) /usr/local/libexec/c-lightning/plugins/autoclean
2024-09-27T21:07:53.219Z DEBUG   plugin-manager: started(12) /usr/local/libexec/c-lightning/plugins/chanbackup
2024-09-27T21:07:53.234Z DEBUG   plugin-manager: started(13) /usr/local/libexec/c-lightning/plugins/commando
2024-09-27T21:07:53.250Z DEBUG   plugin-manager: started(14) /usr/local/libexec/c-lightning/plugins/fetchinvoice
2024-09-27T21:07:53.266Z DEBUG   plugin-manager: started(15) /usr/local/libexec/c-lightning/plugins/funder
2024-09-27T21:07:53.283Z DEBUG   plugin-manager: started(16) /usr/local/libexec/c-lightning/plugins/topology
2024-09-27T21:07:53.299Z DEBUG   plugin-manager: started(17) /usr/local/libexec/c-lightning/plugins/keysend
2024-09-27T21:07:53.315Z DEBUG   plugin-manager: started(18) /usr/local/libexec/c-lightning/plugins/offers
2024-09-27T21:07:53.331Z DEBUG   plugin-manager: started(19) /usr/local/libexec/c-lightning/plugins/pay
2024-09-27T21:07:53.346Z DEBUG   plugin-manager: started(20) /usr/local/libexec/c-lightning/plugins/recover
2024-09-27T21:07:53.362Z DEBUG   plugin-manager: started(21) /usr/local/libexec/c-lightning/plugins/txprepare
2024-09-27T21:07:53.378Z DEBUG   plugin-manager: started(22) /usr/local/libexec/c-lightning/plugins/cln-renepay
2024-09-27T21:07:53.394Z DEBUG   plugin-manager: started(23) /usr/local/libexec/c-lightning/plugins/spenderp
2024-09-27T21:07:53.410Z DEBUG   plugin-manager: started(24) /usr/local/libexec/c-lightning/plugins/sql
2024-09-27T21:07:53.426Z DEBUG   plugin-manager: started(25) /usr/local/libexec/c-lightning/plugins/bookkeeper
2024-09-27T21:07:53.446Z DEBUG   plugin-manager: started(26) /usr/local/libexec/c-lightning/plugins/clnrest/clnrest.py
2024-09-27T21:07:57.611Z DEBUG   lightningd: io_break: check_plugins_manifests
2024-09-27T21:07:57.611Z DEBUG   lightningd: io_loop_with_timers: plugins_init
lightningd: --sauron-api-endpoint=https://blockstream.info/api/: unknown option

@ca-ruz
Copy link
Contributor

ca-ruz commented Oct 5, 2024

@chrisguida mempool.space support should be working now.

@ca-ruz
Copy link
Contributor

ca-ruz commented Oct 5, 2024

@iorch I tried it again with the new docker image you sent me and I got this error message:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
clnrest 24.2 requires pyln-client<25.0,>=24.2, but you have pyln-client 0.9.3 which is incompatible.
pyln-testing 24.2 requires pyln-client>=23, but you have pyln-client 0.9.3 which is incompatible.

also, @chrisguida noticed this:

Collecting pyln-client~=0.9.2 (from -r ./archived/paytest/requirements.txt (line 1))
  Using cached pyln_client-0.9.3-py3-none-any.whl.metadata (3.2 kB)
Collecting pyln-proto~=0.9.2 (from -r ./archived/paytest/requirements.txt (line 2))

It's installing plugins that are already archived, and it shouldn't.

@chrisguida
Copy link
Collaborator

@iorch

Thinking about this more, I think the best way for us to implement this may be just to reuse the plugin installation code from the CI

see https://github.com/lightningd/plugins/blob/master/.ci/test.py for the code that installs the python dependencies

That way all of the plugins should work

@chrisguida
Copy link
Collaborator

@iorch are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile: add instructions for what it's for and how to run it
3 participants