f Don't update but insert failed payments

lightningdevkit · Apr 6, 2023 · 3380625 · 3380625
1 parent 096c789
commit 3380625
Showing 1 changed file with 21 additions and 15 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -1040,13 +1040,16 @@ impl Node {
 			Err(payment::PaymentError::Sending(e)) => {
 				log_error!(self.logger, "Failed to send payment: {:?}", e);
 
-				self.payment_store.update(
-					&payment_hash,
-					None,
-					None,
-					None,
-					Some(PaymentStatus::Failed),
-				)?;
+				let payment = PaymentDetails {
+					preimage: None,
+					hash: payment_hash,
+					secret: payment_secret,
+					amount_msat: invoice.amount_milli_satoshis(),
+					direction: PaymentDirection::Outbound,
+					status: PaymentStatus::Failed,
+				};
+				self.payment_store.insert(payment)?;
+
 				Err(Error::PaymentFailed)
 			}
 		}
@@ -1120,9 +1123,9 @@ impl Node {
 					hash: payment_hash,
 					preimage: None,
 					secret: payment_secret,
+					amount_msat: Some(amount_msat),
 					direction: PaymentDirection::Outbound,
 					status: PaymentStatus::Pending,
-					amount_msat: Some(amount_msat),
 				};
 				self.payment_store.insert(payment)?;
 
@@ -1135,13 +1138,16 @@ impl Node {
 			Err(payment::PaymentError::Sending(e)) => {
 				log_error!(self.logger, "Failed to send payment: {:?}", e);
 
-				self.payment_store.update(
-					&payment_hash,
-					None,
-					None,
-					None,
-					Some(PaymentStatus::Failed),
-				)?;
+				let payment = PaymentDetails {
+					hash: payment_hash,
+					preimage: None,
+					secret: payment_secret,
+					amount_msat: Some(amount_msat),
+					direction: PaymentDirection::Outbound,
+					status: PaymentStatus::Failed,
+				};
+				self.payment_store.insert(payment)?;
+
 				Err(Error::PaymentFailed)
 			}
 		}