Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify interface types and expose connect / disconnect methods #52

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Unify interface types and expose connect / disconnect methods #52

merged 2 commits into from
Apr 25, 2023

Commits on Apr 25, 2023

  1. Unify Node API around Rust types 

    So far the interface sometimes took `String`s, `&str`s, or actual Rust
types. Moreover we sometimes took the arguments by reference and
sometimes not.

In order to make the interface more uniform, we here take a step towards
the Rust types and taking arguments by reference.

Note that some of the affected parts are due to change in the future,
e.g., once we transition to using upstream's `NetAddress` for peer
addresses.
    @tnull
    tnull committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    80f64db View commit details
    Browse the repository at this point in the history

  2. Implement and expose connect/disconnect

    @tnull
    tnull committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    f07ec07 View commit details
    Browse the repository at this point in the history